https://bugzilla.redhat.com/show_bug.cgi?id=1376635 Andrea Musuruane <musuruan@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |musuruan@xxxxxxxxx --- Comment #1 from Andrea Musuruane <musuruan@xxxxxxxxx> --- I had a quick glance at the spec file and I noticed the following issues: - you can drop the Group tag https://fedoraproject.org/wiki/Packaging:Guidelines#Tags_and_Sections - you must Requires: hicolor-icon-theme because you install files in %{_datadir}/icons/hicolor/ - you may change "make %{?_smp_mflags}" in %make_build - you may change "make DESTDIR=%{buildroot} PREFIX=%{_prefix} install" in "%make_install PREFIX=%{_prefix}" - you must remove LICENCE from %doc and add it to %license https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text - you must run appstream-util validate-relax (in %check or %install) and have BuildRequires: libappstream-glib https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx