https://bugzilla.redhat.com/show_bug.cgi?id=1374138 --- Comment #5 from Pavel Raiskup <praiskup@xxxxxxxxxx> --- (In reply to Randy Barlow from comment #4) > * Use the %license macro instead of the %doc macro on the LICENSE file. > * Each subpackage should also have the %license macro. Done. > * I think there may be an elixir executable in Fedora now, so the comment in > the install section might not be accurate. Removed. > * You've got a few lines of commented code - can you remove those? I removed some of them, but feel free to submit pull request against github repo. TBH, to remove others would be too time expensive for me :( I don't know most of the file-types and also I don't want to do a huge research. > * You might want to drop the explicit Requires: on libraries to get rid of the > rpmlint errors. Done. > * Maybe you can get the %files sections into that fancy macro so you don't > have to write all those subpackages' files sections out? Done. > * rpmlint is upset about the erlang script interpreter: E: > wrong-script-interpreter /usr/share/vim/vimfiles/syntax_checkers/erlang > /erlang_check_file.erl /usr/bin/env escript. There are a few more of these > about other languages as well. Ok, I tried to fix this too. > Once you fix those first two items, let me know and I'll check it out again. Please take another look, and thanks for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx