[Bug 1374138] Review Request: syntastic - A vim plugins to check syntax for programming languages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1374138



--- Comment #4 from Randy Barlow <randy@xxxxxxxxxxxxxxxxxxxxx> ---
Some things to fix:

* Use the %license macro instead of the %doc macro on the LICENSE file.
* Each subpackage should also have the %license macro.


Optional
* I think there may be an elixir executable in Fedora now, so the comment in
the
  install section might not be accurate.
* You've got a few lines of commented code - can you remove those?
* You might want to drop the explicit Requires: on libraries to get rid of the
  rpmlint errors.
* Maybe you can get the %files sections into that fancy macro so you don't have
  to write all those subpackages' files sections out?
* rpmlint is upset about the erlang script interpreter: E:
  wrong-script-interpreter /usr/share/vim/vimfiles/syntax_checkers/erlang
  /erlang_check_file.erl /usr/bin/env escript. There are a few more of these
  about other languages as well.


Once you fix those first two items, let me know and I'll check it out again.
Thanks for bringing this back!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]