[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1336552



--- Comment #9 from Christoph Junghans <junghans@xxxxxxxxx> ---
(In reply to Dominik 'Rathann' Mierzejewski from comment #8)
> Please post both spec and srpm URL each time you make a revision.
See below
> 
> Issues found in current revision:
> 
> %install
> [...]
> cp %{S:1} %{S:2} %{buildroot}/%{_docdir}/%{name}
Done
> Could you take a look at the test suite output? It's showing diffs, but
> there are apparently only whitespace differences because as far as I can
> tell all the numbers are the same.
The lines just came out in the wrong order, but the results match, patch added
> 
> Please fix this rpmlint warning:
> 
> exodusii-devel.x86_64: W: no-dependency-on exodusii/exodusii-libs/libexodusii
Done
> -doc subpackage should be noarch (BuildArch: noarch).
Done
> 
> Rpmlint (installed packages)
> ----------------------------
> exodusii.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libexoIIv2c-5.14.0.so /lib64/libhdf5.so.10
> exodusii.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libexoIIv2c-5.14.0.so /lib64/libhdf5_hl.so.10
> exodusii.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libexoIIv2c-5.14.0.so /lib64/libz.so.1
> exodusii.x86_64: W: shared-lib-calls-exit /usr/lib64/libexoIIv2c-5.14.0.so
> exit@GLIBC_2.2.5
> exodusii.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libexoIIv2for-5.14.0.so /lib64/libnetcdf.so.11
> exodusii.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libexoIIv2for-5.14.0.so /lib64/libhdf5.so.10
> exodusii.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libexoIIv2for-5.14.0.so /lib64/libhdf5_hl.so.10
> exodusii.x86_64: W: unused-direct-shlib-dependency
> /usr/lib64/libexoIIv2for-5.14.0.so /lib64/libz.so.1
> exodusii-devel.x86_64: W: no-dependency-on exodusii/exodusii-libs/libexodusii
> 
> It looks like the libraries are linked to libhdf5 and libhdf5_hl
> unnecessarily. That is, they don't seem to reference any symbols from
> libhdf5*. Please verify and fix if necessary.
How did you get these warning? I ran rpmlint before, but didn't see these.

Anyhow, they linked against libz and libhdf5 to support static libs, which we
don't build. Fix that over-linking bug

> README is packaged twice (once in main package and second time in -doc).
Done

Spec URL:
https://raw.githubusercontent.com/junghans/fedora-review/master/exodusii/exodusii.spec
SRPM URL:
https://github.com/junghans/fedora-review/raw/master/exodusii/exodusii-6.02-3.fc24.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]