[Bug 1336552] Review Request: exodusii - Library to store and retrieve transient finite element data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1336552



--- Comment #8 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
Please post both spec and srpm URL each time you make a revision.

Issues found in current revision:

%install
[...]
cp %{S:1} %{S:2} %{buildroot}/%{_docdir}/%{name}

please use either cp -p or install -p here.
(https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps)

Could you take a look at the test suite output? It's showing diffs, but there
are apparently only whitespace differences because as far as I can tell all the
numbers are the same.

Please fix this rpmlint warning:

exodusii-devel.x86_64: W: no-dependency-on exodusii/exodusii-libs/libexodusii

This is actually mandated by the guidelines
(https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package).

-doc subpackage should be noarch (BuildArch: noarch).

Rpmlint (installed packages)
----------------------------
exodusii.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libexoIIv2c-5.14.0.so /lib64/libhdf5.so.10
exodusii.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libexoIIv2c-5.14.0.so /lib64/libhdf5_hl.so.10
exodusii.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libexoIIv2c-5.14.0.so /lib64/libz.so.1
exodusii.x86_64: W: shared-lib-calls-exit /usr/lib64/libexoIIv2c-5.14.0.so
exit@GLIBC_2.2.5
exodusii.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libexoIIv2for-5.14.0.so /lib64/libnetcdf.so.11
exodusii.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libexoIIv2for-5.14.0.so /lib64/libhdf5.so.10
exodusii.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libexoIIv2for-5.14.0.so /lib64/libhdf5_hl.so.10
exodusii.x86_64: W: unused-direct-shlib-dependency
/usr/lib64/libexoIIv2for-5.14.0.so /lib64/libz.so.1
exodusii-devel.x86_64: W: no-dependency-on exodusii/exodusii-libs/libexodusii

It looks like the libraries are linked to libhdf5 and libhdf5_hl unnecessarily.
That is, they don't seem to reference any symbols from libhdf5*. Please verify
and fix if necessary.

README is packaged twice (once in main package and second time in -doc).

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]