https://bugzilla.redhat.com/show_bug.cgi?id=1350257 --- Comment #22 from Antonio Trande <anto.trande@xxxxxxxxx> --- (In reply to Dave Love from comment #21) > Apologies for the delay, what with being away, and having to spend a > lot more time on this than I expected. > > (In reply to Antonio Trande from comment #20) > > SPEC: > > http://copr-dist-git.fedorainfracloud.org/cgit/sagitter/petsc/petsc.git/ > > plain/petsc.spec?id=79c67a625efcd1f39a24705c8ce881977f2bb0b1 > > > > SRPM: > > https://copr-be.cloud.fedoraproject.org/results/sagitter/petsc/fedora- > > rawhide-x86_64/00446542-petsc/petsc-3.7.2-11.fc26.src.rpm > > > For el6, use environment-modules consistently for build- and > install-time requires, rather than the installation requiring Lmod. > You'll need to define _modulesdir for el6 if you use it. > > Can we avoid the need for a module anyhow? It doesn't make a lot of > sense for a library like this. I don't understand the environment > variable usage, but presumably the values could be hard-wired for the > packaging. > > > I don't think the /usr/share/petsc*/conf directories should be in the > main packages (or even in the -devel ones?) > Do you think that modules and conf are useless? > I still don't understand the SETOPT_FLAGS thing, which definitely > isn't necessary, and why flags are set separately (and differently?) > at compile- and run-time. None of that seems to be necessary. > Configure does not like -D_FORTIFY_SOURCE flag. I set SETOPT_FLAGS in order to indulge a specific test. Only Make flags are effectively used for building. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx