https://bugzilla.redhat.com/show_bug.cgi?id=1366784 Jan Včelák <jv+fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(jskarvad@redhat.c | |om) --- Comment #5 from Jan Včelák <jv+fedora@xxxxxxxxx> --- (In reply to Jaroslav Škarvada from comment #4) > Sorry for delay, I was sick. Don't worry. :-) > You should probably list gcc and all other build deps, according to the: > https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRequires_2 > You can only rely that there is a functional RPM and the shell in the build > root. This was changed in the guidelines and there is now no "safe defaults > in the buildroot", but I am a bit relaxed about this requirement. Done. The only added dependency is gcc. I haven't noticed any other deps. > > I would like to keep the packages independent. It's just documentation. You > > don't need the library or headers to read it. > > > I think it's a bit useless to install documentation without the library, but > I have no problem with it. Let's keep it that way then, please. > I think the main reason of the bundled keyword is to track the security > related problems with the bundled libs. Without version it's impossible to > track it. However, I think that local documentation may pose little or none > risk, so probably the bundled keywords are not needed in this case. IIRC in > the past each bundled keyword required FESCO exception, but currently I > cannot find anything about it in the guidelines, so probably this > requirement has been dropped. I think the exceptions is not needed anymore. Anyway, I've added versions for js-jquery and js-underscore. And I've dropped js-sizzle because it's part of this particular version of jquery and I'm unable to determine exact version (I know the commit number but it's not tagged so it makes any comparison useless). > I would probably enforce unversioned docdir on > RHEL-7 and Fedora if there > is no _pkgdocdir macro, e.g.: > > %if 0%{?rhel} <= 7 && 0%{!?fedora:1} > {!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}-%{version}} > %else > {!?_pkgdocdir: %global _pkgdocdir %{_docdir}/%{name}} > %endif I've remove all defines to support EPEL for now because it needs more tuning and it failed to build. I would like to get the package included in current Fedora for now and maybe I'l fix it for EPEL 7 later. The above will probably make the trick and I'll also have to treat %license somehow. Updated SPEC: https://jvcelak.fedorapeople.org/review/mpdecimal/2.4.2-4/mpdecimal.spec Update SRPM: https://jvcelak.fedorapeople.org/review/mpdecimal/mpdecimal-2.4.2-4.fc24.src.rpm Binary build: https://copr.fedorainfracloud.org/coprs/jvcelak/mpdecimal/build/447839/ Thanks! I think all remarks have been addressed. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx