https://bugzilla.redhat.com/show_bug.cgi?id=1369471 --- Comment #3 from Yanis Guenane <yguenane@xxxxxxxxxx> --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://fedoraproject.org/wiki/Packaging:Guidelines - Package contains Requires: ruby(release). ===== MUST items ===== Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 37 files have unknown license. Detailed output of licensecheck in /home/spredzy/rpmbuild/SPECS/1369471 -rubygem-fluent-plugin-secure-forward/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/gems, /usr/share/gems/doc [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [ ]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package does not contain Requires: ruby(abi). ===== SHOULD items ===== Generic: [ ]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rubygem- fluent-plugin-secure-forward-doc [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [x]: Gem package should exclude cached Gem. [x]: Gem should use %gem_install macro. [x]: gems should not require rubygems package [x]: Specfile should use macros from rubygem-devel package. [x]: Test suite should not be run by rake. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) Installation errors ------------------- INFO: mock.py version 1.2.14 starting (python version = 3.4.3)... Start: init plugins INFO: selinux enabled Finish: init plugins Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled yum cache Start: cleaning yum metadata Finish: cleaning yum metadata INFO: enabled ccache Mock Version: 1.2.14 INFO: Mock Version: 1.2.14 Finish: chroot init INFO: installing package(s): /home/spredzy/rpmbuild/SPECS/1369471-rubygem-fluent-plugin-secure-forward/results/rubygem-fluent-plugin-secure-forward-0.4.3-1.fc23.noarch.rpm /home/spredzy/rpmbuild/SPECS/1369471-rubygem-fluent-plugin-secure-forward/results/rubygem-fluent-plugin-secure-forward-doc-0.4.3-1.fc23.noarch.rpm ERROR: Command failed. See logs for output. # /usr/bin/yum-deprecated --installroot /var/lib/mock/fedora-23-x86_64/root/ --releasever 23 install /home/spredzy/rpmbuild/SPECS/1369471-rubygem-fluent-plugin-secure-forward/results/rubygem-fluent-plugin-secure-forward-0.4.3-1.fc23.noarch.rpm /home/spredzy/rpmbuild/SPECS/1369471-rubygem-fluent-plugin-secure-forward/results/rubygem-fluent-plugin-secure-forward-doc-0.4.3-1.fc23.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: rubygem-fluent-plugin-secure-forward-0.4.3-1.fc23.noarch.rpm rubygem-fluent-plugin-secure-forward-doc-0.4.3-1.fc23.noarch.rpm rubygem-fluent-plugin-secure-forward-0.4.3-1.fc23.src.rpm rubygem-fluent-plugin-secure-forward.noarch: W: spelling-error Summary(en_US) Fluentd -> Fluent, Fluent d rubygem-fluent-plugin-secure-forward.noarch: W: no-documentation rubygem-fluent-plugin-secure-forward.noarch: W: pem-certificate /usr/share/gems/gems/fluent-plugin-secure-forward-0.4.3/example/certs/cert.pem rubygem-fluent-plugin-secure-forward.noarch: W: pem-certificate /usr/share/gems/gems/fluent-plugin-secure-forward-0.4.3/example/certs/cert-with-intermediate.pem rubygem-fluent-plugin-secure-forward.noarch: W: pem-certificate /usr/share/gems/gems/fluent-plugin-secure-forward-0.4.3/example/certs/root.pem rubygem-fluent-plugin-secure-forward.noarch: W: pem-certificate /usr/share/gems/gems/fluent-plugin-secure-forward-0.4.3/example/cacerts2/ca_cert.pem rubygem-fluent-plugin-secure-forward.noarch: W: pem-certificate /usr/share/gems/gems/fluent-plugin-secure-forward-0.4.3/example/cacerts1/ca_cert.pem rubygem-fluent-plugin-secure-forward.noarch: W: pem-certificate /usr/share/gems/gems/fluent-plugin-secure-forward-0.4.3/example/certs/testing-intermediate.pem rubygem-fluent-plugin-secure-forward.noarch: W: pem-certificate /usr/share/gems/gems/fluent-plugin-secure-forward-0.4.3/example/certs/testing-server.pem rubygem-fluent-plugin-secure-forward.noarch: W: no-manual-page-for-binary secure-forward-ca-generate rubygem-fluent-plugin-secure-forward.src: W: spelling-error Summary(en_US) Fluentd -> Fluent, Fluent d 3 packages and 0 specfiles checked; 0 errors, 11 warnings. Diff spec file in url and in SRPM --------------------------------- --- /home/spredzy/rpmbuild/SPECS/1369471-rubygem-fluent-plugin-secure-forward/srpm/rubygem-fluent-plugin-secure-forward.spec 2016-08-29 12:56:23.575449648 +0200 +++ /home/spredzy/rpmbuild/SPECS/1369471-rubygem-fluent-plugin-secure-forward/srpm-unpacked/rubygem-fluent-plugin-secure-forward.spec 2016-08-29 12:47:53.000000000 +0200 @@ -11,4 +11,5 @@ Patch0: fluent-plugin-secure-forward-0.4.3.usr_bin_ruby.patch BuildRequires: rubygems-devel +#BuildRequires: rubygem-rake Requires: rubygem-proxifier Requires -------- rubygem-fluent-plugin-secure-forward (rpmlib, GLIBC filtered): /usr/bin/ruby ruby(rubygems) rubygem(fluentd) rubygem(proxifier) rubygem(resolve-hostname) rubygem-proxifier rubygem-resolve-hostname rubygem-fluent-plugin-secure-forward-doc (rpmlib, GLIBC filtered): rubygem-fluent-plugin-secure-forward Provides -------- rubygem-fluent-plugin-secure-forward: rubygem(fluent-plugin-secure-forward) rubygem-fluent-plugin-secure-forward rubygem-fluent-plugin-secure-forward-doc: rubygem-fluent-plugin-secure-forward-doc Source checksums ---------------- https://rubygems.org/gems/fluent-plugin-secure-forward-0.4.3.gem : CHECKSUM(SHA256) this package : 5ecb757cdfc6e1bf928ba5a9f1820d66a97393a131e3b17816bf73f185f8f5a7 CHECKSUM(SHA256) upstream package : 5ecb757cdfc6e1bf928ba5a9f1820d66a97393a131e3b17816bf73f185f8f5a7 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1369471 Buildroot used: fedora-23-x86_64 Active plugins: Generic, Ruby, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx