[Bug 1369560] Review Request: snapd-xdg-open - Bridge allowing (untrusted) snap applications to use xdg-open

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1369560



--- Comment #2 from Neal Gompa <ngompa13@xxxxxxxxx> ---
Initial issues:

* Not properly set up for pre-release. It is perfectly acceptable to package up
snapshot pre-releases, provided that the guidelines are followed for versioning
them: https://fedoraproject.org/wiki/Packaging:Versioning#Pre-Release_packages

* URL is invalid. While it does properly redirect, I would strongly prefer to
see the correct URL set here, which I understand it to be
"https://github.com/snapcore/snapd-xdg-open";

* Source0 is invalid. This is a serious problem. Now, since you're currently
using snapshots, you should follow the guidelines for snapshot URLs, as
mentioned here:
https://fedoraproject.org/wiki/Packaging:SourceURL#Commit_Revision

A suggestion: You can set the source URL to
"https://github.com/snapcore/snapd-xdg-open/archive/%{commit0}/%{name}-%{shortcommit0}.tar.gz";,
which will work with spectool to produce a proper snapshot. You'll need to add
"-n %{name}-%{commit0}" to the %setup invocation, also.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]