[Bug 1369708] Review Request: tpm2-tss - TPM2.0 Software Stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1369708



--- Comment #2 from yunying.sun@xxxxxxxxx ---
(In reply to Igor Gnatenko from comment #1)
> > BuildRequires:  pkgconfig
> > BuildRequires:  libcmocka-devel
> BuildRequires: pkgconfig(cmocka)
> 
> > CONFIG_SITE=$(pwd)/lib/default_config.site ./configure
> export CONFIG_SITE=$(pwd)/lib/default_config.site
> %configure
> 
> > make %{?_smp_mflags}
> %make_build
> 
> * Missing BuildRequires: gcc
> * Redundant rm -rf $RPM_BUILD_ROOT
> * Missing -devel subpackage which contains headers and unversioned .so
> * Globs are too relax (/me guessing package contains .la and .a files)

Thanks Igor, for your quick review and comments.
I will update spec accordingly.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]