https://bugzilla.redhat.com/show_bug.cgi?id=1334611 Igor Gnatenko <ignatenko@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? --- Comment #6 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- (In reply to pjp from comment #5) > Hello Igor, > > (In reply to Igor Gnatenko from comment #4) > > You build from git checkout, but you still have release version. Or change > > release to respect shortcommit or remove commit hashes and build released > > version. > > It is a released version. The commit hash is used for the tarball because > rpmlint(1) complains about resolving github release URLs like below > > https://github.com/skontar/cvss/archive/v1.2.tar.gz > > It does not have package name in it. It is a known issue. -> %{url}/archive/v%{version}/%{srcname}-%{version}.tar.gz > > Please see: > -> https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL > > > > > Summary: CVSS2/3 library with interactive calculator for Python 2 & 3 > > Summary: CVSS2/3 library with interactive calculator > > Okay. > > > > BuildRequires: python-setuptools > > BuildRequires: python2-setuptools > > BuildRequires: python3-setuptools > > Okay. > > > * %{_bindir}/cvss_calculator should be referenced only from python3 version > > Wouldn't it be required with python 2.x version ? Then you should rename it. But if they produce same result you should package only py3 version. So it should go only under python3- subpkg. > > > * Use %{summary} from subpackages to not duplicate text > > Okay. > > Thank you so much. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx