[Bug 1334611] Review request: python-cvss CVSS2/ 3 library with interactive calculator for Python v2 & v3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1334611



--- Comment #5 from pjp <pj.pandit@xxxxxxxxxxx> ---
Hello Igor,

(In reply to Igor Gnatenko from comment #4)
> You build from git checkout, but you still have release version. Or change
> release to respect shortcommit or remove commit hashes and build released
> version.

  It is a released version. The commit hash is used for the tarball because
rpmlint(1) complains about resolving github release URLs like below

  https://github.com/skontar/cvss/archive/v1.2.tar.gz

It does not have package name in it. It is a known issue.

Please see:
 -> https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL


> > Summary:        CVSS2/3 library with interactive calculator for Python 2 & 3
> Summary:        CVSS2/3 library with interactive calculator

  Okay.

> > BuildRequires:  python-setuptools
> BuildRequires: python2-setuptools
> BuildRequires: python3-setuptools

  Okay.

> * %{_bindir}/cvss_calculator should be referenced only from python3 version

  Wouldn't it be required with python 2.x version ?

> * Use %{summary} from subpackages to not duplicate text

  Okay.

Thank you so much.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]