[Bug 1366028] Review Request: python-flask-migrate - SQLAlchemy database migrations for Flask applications using Alembic

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1366028

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |POST
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
rpmlint says:
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask-multidb/env.py
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask-multidb/script.py.mako
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask/env.py
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask-multidb/README
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask/script.py.mako
python2-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python2.7/site-packages/flask_migrate/templates/flask/README
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask/README
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask-multidb/script.py.mako
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask-multidb/README
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask-multidb/env.py
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask/script.py.mako
python3-flask-migrate.noarch: E: script-without-shebang
/usr/lib/python3.5/site-packages/flask_migrate/templates/flask/env.py

→ please chmod

python-flask-migrate.src:89: W: macro-in-comment %check
python-flask-migrate.src:90: W: macro-in-comment %{__python2}
python-flask-migrate.src:92: W: macro-in-comment %{__python3}
python-flask-migrate.src:93: W: macro-in-comment %endif

%sum macro is not needed, just use Summary: normally the first time, and then
Summary: %{summary} in the subsequent ones.

You don't need to remove .egg-info, this guideline has been rescinded.

%description could be extended a bit.

+ package name is OK
+ license is acceptable (MIT)
+ license is specified correctly
+ latest version
+ modern python template is used
+ %python_provide is used
+ build/requires/BR look OK
+ no scriptlets necessary
+ fedora-review is happy
+ rpmlint output above, please fix the issues

Package is APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]