https://bugzilla.redhat.com/show_bug.cgi?id=1350143 --- Comment #6 from Dave Johansen <davejohansen@xxxxxxxxx> --- (In reply to Antonio Trande from comment #5) > Hi Dave. > > (In reply to Dave Johansen from comment #4) > > Sorry for the delay. We moved and I haven't had time to work on this sort of > > thing. > > > > > > [!]: Patches link to upstream bugs/comments/lists or are otherwise > > > justified. > > > > Fixed. > > I dont see any comment. Sorry, the file wasn't uploaded before but it's there now. > > > Generic: > > > [!]: Avoid bundling fonts in non-fonts packages. > > > Note: Package contains font files > > > > This came up during the original review of cppformat and the general > > consensus was that it wasn't an issue: > > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/ > > message/EKVX5GCQUFINUYBRGFD2JQHF2UXUBBVV/ > > There is a similar issue in this review: > https://bugzilla.redhat.com/show_bug.cgi?id=1362265#c16 I'm using the pre-built documentation because it can't be built in Fedora right now, so unfortunately I can't do that sort of fix. > > > fmt.x86_64: W: tag-in-description C Provides: > > > fmt.x86_64: W: tag-in-description C Obsoletes: > > > > Is there something wrong with my Provides/Obsoletes? > > Are under %description section; move them after the BuildRequires: line. Fixed. > > The updated .spec file with the fixes is at: > > https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec > > Please, include these header files > > %exclude %{_includedir}/fmt/ostream.h > %exclude %{_includedir}/fmt/posix.h > %exclude %{_includedir}/fmt/time.h > > I need them for packaging other software. Are these useful without the .cc files? My initial thought would be that if I'm going to package the "header only" files that it should be in a separate package. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx