https://bugzilla.redhat.com/show_bug.cgi?id=1350143 --- Comment #5 from Antonio Trande <anto.trande@xxxxxxxxx> --- Hi Dave. (In reply to Dave Johansen from comment #4) > Sorry for the delay. We moved and I haven't had time to work on this sort of > thing. > > > [!]: Patches link to upstream bugs/comments/lists or are otherwise > > justified. > > Fixed. I dont see any comment. > > > > Generic: > > [!]: Avoid bundling fonts in non-fonts packages. > > Note: Package contains font files > > This came up during the original review of cppformat and the general > consensus was that it wasn't an issue: > https://lists.fedoraproject.org/archives/list/devel@xxxxxxxxxxxxxxxxxxxxxxx/ > message/EKVX5GCQUFINUYBRGFD2JQHF2UXUBBVV/ There is a similar issue in this review: https://bugzilla.redhat.com/show_bug.cgi?id=1362265#c16 > > > fmt.x86_64: W: tag-in-description C Provides: > > fmt.x86_64: W: tag-in-description C Obsoletes: > > Is there something wrong with my Provides/Obsoletes? Are under %description section; move them after the BuildRequires: line. > > > fmt-devel.x86_64: W: only-non-binary-in-usr-lib > > I don't understand what this is warning about. It's a false positive. > > The updated .spec file with the fixes is at: > https://daveisfera.fedorapeople.org/fmt_3.0.0/fmt.spec Please, include these header files %exclude %{_includedir}/fmt/ostream.h %exclude %{_includedir}/fmt/posix.h %exclude %{_includedir}/fmt/time.h I need them for packaging other software. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx