https://bugzilla.redhat.com/show_bug.cgi?id=1346038 Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #22 from Douglas Schilling Landgraf <dougsland@xxxxxxxxxx> --- Package approved. * Translations are not included in this .tar.gz, stored in zanata (out of scope for this compat package) and the others locale warnings/errors as well. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/fedora/python- blivet1/diff.txt See: http://fedoraproject.org/wiki/Packaging/SourceURL ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. Note: Cannot run licensecheck: Command 'licensecheck -r /var/lib/mock/fedora-24-x86_64/root/builddir/build/BUILD/blivet-1.20.3' returned non-zero exit status 1 [X]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/en-GB, /usr/share/locale/de- CH, /usr/share/locale/pt-BR, /usr/share/locale/kw@kkcor, /usr/share/locale/zh-HK, /usr/share/locale/zh-CN, /usr/share/locale/kw_GB/LC_MESSAGES, /usr/share/locale/kw@kkcor/LC_MESSAGES, /usr/share/locale/kw@uccor, /usr/share/locale/zh-TW, /usr/share/locale/en-GB/LC_MESSAGES, /usr/share/locale/zh-TW/LC_MESSAGES, /usr/share/locale/bn- IN/LC_MESSAGES, /usr/share/locale/de-CH/LC_MESSAGES, /usr/share/locale/wba/LC_MESSAGES, /usr/share/locale/kw_GB, /usr/share/locale/kw-GB, /usr/share/locale/zh-CN/LC_MESSAGES, /usr/share/locale/zh-HK/LC_MESSAGES, /usr/share/locale/pt- BR/LC_MESSAGES, /usr/share/locale/kw-GB/LC_MESSAGES, /usr/share/locale/kw@uccor/LC_MESSAGES, /usr/share/locale/wba, /usr/share/locale/bn-IN [X]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/en-GB, /usr/share/locale/en-GB/LC_MESSAGES, /usr/share/locale/zh- TW/LC_MESSAGES, /usr/share/locale/de-CH, /usr/share/locale/bn- IN/LC_MESSAGES, /usr/share/locale/pt-BR, /usr/share/locale/de- CH/LC_MESSAGES, /usr/share/locale/wba/LC_MESSAGES, /usr/share/locale/kw@kkcor, /usr/share/locale/zh-HK, /usr/share/locale/kw_GB, /usr/share/locale/kw-GB, /usr/share/locale /zh-CN/LC_MESSAGES, /usr/share/locale/zh-CN, /usr/share/locale/kw_GB/LC_MESSAGES, /usr/share/locale/zh- HK/LC_MESSAGES, /usr/share/locale/pt-BR/LC_MESSAGES, /usr/share/locale /kw-GB/LC_MESSAGES, /usr/share/locale/kw@kkcor/LC_MESSAGES, /usr/share/locale/kw@uccor/LC_MESSAGES, /usr/share/locale/kw@uccor, /usr/share/locale/zh-TW, /usr/share/locale/wba, /usr/share/locale/bn- IN [X]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python2.7/site- packages/blivet/formats(python-blivet), /usr/lib/python2.7/site- packages/blivet/devicelibs(python-blivet), /usr/lib/python2.7/site- packages/blivet/tasks(python-blivet), /usr/lib/python2.7/site- packages/blivet(python-blivet), /usr/lib/python2.7/site- packages/blivet/devices(python-blivet) [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: The spec file handles locales properly. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [X]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 645120 bytes in 8 files. [X]: Package complies to the Packaging Guidelines [X]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [X]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [X]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [X]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [X]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [X]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Uses parallel make %{?_smp_mflags} macro. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python-blivet1-1.20.3-5.fc24.noarch.rpm python-blivet1-1.20.3-5.fc24.src.rpm python-blivet1.noarch: W: incoherent-version-in-changelog 1.20.3-5.fc24 ['1:1.20.3-5.fc24', '1:1.20.3-5'] python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/kw-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/kw-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/pt-BR/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/pt-BR/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-CN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-CN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-HK/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-HK/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/zh-TW/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/zh-TW/LC_MESSAGES/blivet1.mo python-blivet1.src: W: file-size-mismatch blivet-1.20.3.tar.gz = 699962, http://github.com/rhinstaller/blivet/archive/blivet-1.20.3.tar.gz = 391947 2 packages and 0 specfiles checked; 16 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- python-blivet1.noarch: W: incoherent-version-in-changelog 1.20.3-5.fc24 ['1:1.20.3-5.fc24', '1:1.20.3-5'] python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/bn-IN/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/de-CH/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: invalid-lc-messages-dir /usr/share/locale/en-GB/LC_MESSAGES/blivet1.mo python-blivet1.noarch: E: incorrect-locale-subdir /usr/share/locale/kw-GB/LC_MESSAGES/blivet1.mo Requires -------- python-blivet1 (rpmlib, GLIBC filtered): dosfstools e2fsprogs libblockdev-plugins-all libselinux-python lsof parted pyparted python python(abi) python-gobject-base python-hawkey python-kickstart python-pyudev python-six python2-blockdev util-linux Provides -------- python-blivet1: python-blivet1 Source checksums ---------------- http://github.com/rhinstaller/blivet/archive/blivet-1.20.3.tar.gz : CHECKSUM(SHA256) this package : ce17ee5a0320c879416b1bfd5f5e97f33d069501b868d5f6cd9c97bb25d1e5ce CHECKSUM(SHA256) upstream package : c6825857baf79df604c6409f932367ee4834e667397b805fc57b86757c0485eb diff -r also reports differences Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review --rpm-spec -n python-blivet1-1.20.3-5.fc25.src.rpm Buildroot used: fedora-24-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx