[Bug 1346038] Review Request: python-blivet1 - python2/ blivet-1.x compatibility package

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1346038



--- Comment #21 from David Lehman <dlehman@xxxxxxxxxx> ---
New spec and SRPM available:

SRPM:
https://dlehman.fedorapeople.org/python-blivet1/python-blivet1-1.20.3-5.fc25.src.rpm

SPEC: https://dlehman.fedorapeople.org/python-blivet1/python-blivet1.spec


Changes:
- use smp make macro
- remove obsolete Requires: blivet-data which prevented install in mock


> 
> Issues:
> =======
> - Package installs properly.
>   Note: Installation errors (see attachment)
>   See: https://fedoraproject.org/wiki/Packaging:Guidelines
> - Sources used to build the package match the upstream source, as provided
>   in the spec URL.
>   Note: Upstream MD5sum check error, diff is in /home/fedora/python-
>   blivet1/diff.txt
>   See: http://fedoraproject.org/wiki/Packaging/SourceURL

Upstream tarballs do not include translations, hence the difference.

> 
> 
> 
> ===== SHOULD items =====
> 
> Generic:
> [!]: Uses parallel make %{?_smp_mflags} macro.

Fixed.

> 
> 
> ===== EXTRA items =====
> 
> Generic:
> [!]: Rpmlint is run on all installed packages.
>      Note: Mock build failed
>      See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint

Fixed.

> 
> Source checksums
> ----------------
> http://github.com/rhinstaller/blivet/archive/blivet-1.20.3.tar.gz :
>   CHECKSUM(SHA256) this package     :
> ce17ee5a0320c879416b1bfd5f5e97f33d069501b868d5f6cd9c97bb25d1e5ce
>   CHECKSUM(SHA256) upstream package :
> c6825857baf79df604c6409f932367ee4834e667397b805fc57b86757c0485eb
> diff -r also reports differences

Upstream tarball does not include translations so this is expected.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]