[Bug 1359473] Review Request: legendsbrowser - Java-based legends viewer for Dwarf Fortress

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1359473



--- Comment #9 from gil cattaneo <puntogil@xxxxxxxxx> ---
(In reply to Ben Rosser from comment #8)
> javassist does seem to be necessary on the %jpackage_script line in order
> for it to launch and not crash. But if I'm reading the traceback generated
> when it's *not* there correctly, this is because of reflections:
> 
> https://paste.fedoraproject.org/397089/38725146/
> 
> https://github.com/robertjanetzko/LegendsBrowser/blob/master/src/main/java/
> legends/RequestThread.java#L53 

yes is required. Please add as "Requires" if necessary

> > i tried the launcher script but seem fail for unavailable  > legendsbrowser.properties file
> > another "problem" a log file is generated. should be in / var / tmp or temp > directory ...
> 
> It creates legendsbrowser.properties in your current directory when first
> ran if it's not there (and also the logfile in the same directory), so the
> file being missing shouldn't be a problem. .properties seems to just store
> the location legendsbrowser was last ran in and *should* really be in, say,
> ~/.config/legendsbrowser/.
> 
> It would be simple enough to patch the launcher script to run in another
> directory, I guess, but then the log and properties file will still be
> created together. Alternatively I guess the source (e.g.
> https://github.com/robertjanetzko/LegendsBrowser/blob/
> 6ca346eed60cf1dd4e7d620503a16f537963edbc/src/main/java/legends/Application.
> java#L26) could be patched to look for and create them in a different
> place... what do you suggest?

yes for avoid log and props files scattered / dispersed throughout the system
:)

> Once I fix this I'll repost the spec and srpm (with the above issues dealt
> with too).

seem you have missing "Provides:      bundled(leaflet-opacity-controlsjs)" (the
name ... )
https://github.com/lizardtechblog/Leaflet.OpacityControls

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]