https://bugzilla.redhat.com/show_bug.cgi?id=1359473 --- Comment #8 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- > see spec file attached added > Requires: mvn(commons-collections:commons-collections) > Requires: mvn(commons-lang:commons-lang) > because them are missing in classpath Oh, I see. Thanks for posting your updated spec! I'll add these Requires: to mine. > OFL: fontawesome-fonts-web (our spec file use this license) Oh. I skimmed right over the "Font licenses" part of the fontawesome license page for some reason; yes, it should indeed be OFL and not CC-BY. Thanks! > us really necessary javassist? javassist does seem to be necessary on the %jpackage_script line in order for it to launch and not crash. But if I'm reading the traceback generated when it's *not* there correctly, this is because of reflections: https://paste.fedoraproject.org/397089/38725146/ https://github.com/robertjanetzko/LegendsBrowser/blob/master/src/main/java/legends/RequestThread.java#L53 > i tried the launcher script but seem fail for unavailable > legendsbrowser.properties file > another "problem" a log file is generated. should be in / var / tmp or temp > directory ... It creates legendsbrowser.properties in your current directory when first ran if it's not there (and also the logfile in the same directory), so the file being missing shouldn't be a problem. .properties seems to just store the location legendsbrowser was last ran in and *should* really be in, say, ~/.config/legendsbrowser/. It would be simple enough to patch the launcher script to run in another directory, I guess, but then the log and properties file will still be created together. Alternatively I guess the source (e.g. https://github.com/robertjanetzko/LegendsBrowser/blob/6ca346eed60cf1dd4e7d620503a16f537963edbc/src/main/java/legends/Application.java#L26) could be patched to look for and create them in a different place... what do you suggest? Once I fix this I'll repost the spec and srpm (with the above issues dealt with too). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx