[Bug 1358293] Review Request: bcg729 - Opensource implementation of the G.729 codec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1358293



--- Comment #1 from Igor Gnatenko <ignatenko@xxxxxxxxxx> ---
> autoreconf -ivf
move to %build

> PKG_CHECK_MODULES(ORTP, ortp >= 0.21.0,[found_ortp=true],foo=bar)
> PKG_CHECK_MODULES(MEDIASTREAMER, mediastreamer >= 2.8.99,[found_ms2=true],foo=bar)
add BuildRequires: pkgconfig(ortp) and pkgconfig(mediastreamer) if those are in
fedora and you think we should enable those features (don't know what those
packages do, so it's up to you to check them and think if we should enable
them)

> # Fix FSF addresses
don't do that, just report bug in upstream and note link somewhere around
License tag.

> License:       GPLv2
it's GPLv2+ actually

> find %{buildroot} -name '*.la' -exec rm {} \;
find %{buildroot}%{_libdir} -type f -name '*.la' -delete -print

Other things:
* replace bcg729 with %{name} in %files section
* Add spawning test-suite in %check

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]