https://bugzilla.redhat.com/show_bug.cgi?id=1357573 --- Comment #6 from Igor Gnatenko <ignatenko@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #5) > (In reply to Igor Gnatenko from comment #3) > > > BuildRequires: python-setuptools > > BuildRequires: python2-setuptools > > - Also please move BRs under subpackages (just for better look&feel) > > BuildRequires belong to the package as a whole and moving them to > subpackages provides a false feeling that they are relevant (for RPM) for > that subpackage only. So I do not recommend this, however, if the maintainer > wishes to do so, it's not against any guidelines. That's actually true (that it belongs to subpackage) ;) Instead of doing: ... %if %{with python3} BR: python3-devel python3-setuptools %endif ... %if %{with python3} %package -n python3-%{modname} ... %endif it's easier to just put it under subpackage. That's not critical, but just nice to have. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx