https://bugzilla.redhat.com/show_bug.cgi?id=1357573 --- Comment #5 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to Igor Gnatenko from comment #3) > > BuildRequires: python-setuptools > BuildRequires: python2-setuptools > - Also please move BRs under subpackages (just for better look&feel) BuildRequires belong to the package as a whole and moving them to subpackages provides a false feeling that they are relevant (for RPM) for that subpackage only. So I do not recommend this, however, if the maintainer wishes to do so, it's not against any guidelines. > > rm -rf %{pypi_name}.egg-info > it's not on github source Better safe than sorry. > > %{python3_sitelib}/%{srcname}-%{version}-py?.?.egg-info > 1. add trailing slash please, to be sure that it's generated by setuptools > and not distutils Feel free to do that. > 2. if you really want that strict thing here, replace "?.?" with > "%{python3_version}" Feel free to do that. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx