[Bug 1307271] Review Request: vswm - Very Simple Wireless Manager

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1307271



--- Comment #2 from Raphael Groner <projects.rg@xxxxxxxx> ---
+ You can remove those lines cause deprecated/obselete:

BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

rm -rf $RPM_BUILD_ROOT

%clean

%defattr(-,root,root,-)

+ Release is wrong, better start with 1 instead of 0 and use %{?_dist}:

Release: 1%{?_dist}

+ Please fill in a description text for %description.

+ Properly use macros where possible. E.g. %{_bindir} instead of /usr/bin.

+ Use "cp -p" to preserve timestamps. Alternatively you can use install:
install -D vswm -t $RPM_BUILD_ROOT/%{_bindir}

+ Make manpages more generic:

%{_mandir}/man8/vswm.8*

+ Changelog has wrong format, mind the dash:

* Tue Sep 08 2015 Diogo Oliveira de Melo <dmelo87(at)gmail.com> - 0.1-0

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]