Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: stardict-dic-zh_CN - Simplified Chinese(zh_CN) dictionaries for StarDict https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245882 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-07-02 00:32 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 68e539f362de416490b78fed97aba780 stardict-cdict-gb-2.4.2.tar.bz2 d8db9bdbf0dd4856d03e04d3f73d9c5a stardict-cedict-gb-2.4.2.tar.bz2 8e9700798a0ffeed23207b7cf2592246 stardict-langdao-ce-gb-2.4.2.tar.bz2 41a71f5b3952709746dd7e52cf155b8b stardict-langdao-ec-gb-2.4.2.tar.bz2 c175f9bcb88e7513380ad05b291a8a03 stardict-oxford-gb-2.4.2.tar.bz2 745727367e22ab9740256ceaf16cb83d stardict-xdict-ce-gb-2.4.2.tar.bz2 364bcecc126d6d8560728dc487ea9eaf stardict-xdict-ec-gb-2.4.2.tar.bz2 4467d7941f9388f0e01ee3025c400b5c stardict-stardict1.3-2.4.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. - License text is NOT included in package. - no %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Requires: stardict >= 2.4.2 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review