Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: stardict-dic-zh_TW - Traditional Chinese(zh_TW) dictionaries for StarDict https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=245883 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-07-02 00:30 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPM. + source files match upstream. 0349198b9dfcecd9a0f505512bb21d8b stardict-cdict-big5-2.4.2.tar.bz2 80b13d05bd5e975c35afcf4a13113673 stardict-cedict-big5-2.4.2.tar.bz2 50b9423fa578988b5b0544c5b663058a stardict-langdao-ce-big5-2.4.2.tar.bz2 61ceeec1b056a171645af723d3e956fe stardict-langdao-ec-big5-2.4.2.tar.bz2 e54da1d0759ce59f8fbddff7979e9300 stardict-oxford-big5-2.4.2.tar.bz2 + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. - License text is NOT included in package. - no %doc files present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains content. + no static libraries. + no .pc files are present. + no -devel subpackage exists. + no .la files. + no translations are available. + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + no scriptlets are used. + Not a GUI app. + Requires: stardict >= 2.4.2 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review