https://bugzilla.redhat.com/show_bug.cgi?id=1336168 Jan Chaloupka <jchaloup@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jchaloup@xxxxxxxxxx --- Comment #3 from Jan Chaloupka <jchaloup@xxxxxxxxxx> --- Summary: - please provide %{commit}, %{shortcommit}, %{provider} and the usual macros for Go packages. They are handful (and needed) for tooling running over Go projects packaged in Fedora. - as long as the package is for Fedora only, BuildRequires: compiler(go-compiler) is fine. It will not work for epel6, epel7 and RHEL7 as compiler(go-compiler) is not defined there. - provide devel and unit-test subpackages as well (for analysis carried over Go projects in distribution) - to build from de-bundled dependencies, all imports prefixed with "github.com/github/git-lfs/vendor/_nuts/" must be updated. (Remove the prefix). U can use: sed -i "s/github\.com\/github\/git-lfs\/vendor\/_nuts\///" $(find . -name '*.go') After removing the vendor prefix, the following list of deps remains: BuildRequires: golang(github.com/ThomsonReutersEikon/go-ntlm/ntlm) BuildRequires: golang(github.com/bgentry/go-netrc/netrc) BuildRequires: golang(github.com/cheggaaa/pb) BuildRequires: golang(github.com/kr/pty) BuildRequires: golang(github.com/olekukonko/ts) BuildRequires: golang(github.com/rubyist/tracerx) BuildRequires: golang(github.com/spf13/cobra) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx