[Bug 1336161] Review Request: golang-github-ThomsonReutersEikon-go-ntlm - Native implementation of NTLM for Go

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1336161



--- Comment #1 from Jan Chaloupka <jchaloup@xxxxxxxxxx> ---
Summary:
- licence OK
- will not build in epel6 (%license macro is not defined)
- usually structure (with_* removed)
- version is ok (hard to decode the version number from jenkins-ci-2 [1]

Nits:
- unit-test does not have license and docs (add %license License and %doc
README.md as well)

Running rpmlint
golang-github-ThomsonReutersEikon-go-ntlm-0-0.1.gitb00ec39.fc20.src.rpm
golang-github-ThomsonReutersEikon-go-ntlm-devel-0-0.1.gitb00ec39.fc20.noarch.rpm
golang-github-ThomsonReutersEikon-go-ntlm-unit-test-devel-0-0.1.gitb00ec39.fc20.x86_64.rpm
golang-github-ThomsonReutersEikon-go-ntlm-unit-test-devel.x86_64: W:
no-documentation
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=14858213

Up to the nit LGTM.

[1] https://github.com/ThomsonReutersEikon/go-ntlm/releases/tag/jenkins-ci-2

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux