[Bug 1334888] Review Request: python-seesaw - ArchiveTeam seesaw kit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1334888



--- Comment #4 from Ben Rosser <rosser.bjr@xxxxxxxxx> ---
I've unbundled six and added a dependency on python{2,3}-six. I also fixed the
python-Tornado dependency and changed python-sockjs-tornado to be
python2-sockjs-tornado.

For the moment, I've added bundled provides on the JS and CSS:

Provides:       bundled(js-jquery) = 1.7.2
Provides:       bundled(js-smoothie) = 1.9
Provides:       bundled(js-sockjs) = 0.3
Provides:       bundled(reset-css) = 2.0

I may attempt to unbundle some of them later though. js-jquery is packaged in
Fedora, but the version is much newer than what's used in seesaw (2.x vs 1.7),
and research suggested there might be some issues upgrading. The other three
are not even in Fedora, although there is an open review ticket from 2014 for
reset-css  (https://bugzilla.redhat.com/show_bug.cgi?id=1094034).

The license field has been set to "WTFPL and MIT and Public Domain" as a
consequence of this.

I fleshed out the summary and description on the -doc subpackage.

I tried enabling the unit tests. However, test_proc_utf8 fails when invoked as
part of %check, but works just fine when I run "nosetests -v" in the package's
build directory myself. This happens when I'm invoking rpmbuild manually, so I
don't understand what could be different about the RPM environment and my
system's...

The relevant test is here:
https://github.com/ArchiveTeam/seesaw-kit/blob/master/seesaw/externalprocess_test.py#L107
and the specific error was https://paste.fedoraproject.org/374430/50597051/.
The code is just trying to print out a Unicode string.

Spec URL: https://tc01.fedorapeople.org/seesaw/python-seesaw.spec
SRPM URL:
https://tc01.fedorapeople.org/seesaw/python-seesaw-0.9.2-2.fc23.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]