https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman <nhorman@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(robert.amato@inte | |l.com) | |needinfo?(nhorman@xxxxxxxxx | |m) | |needinfo?(nhorman@xxxxxxxxx | |m) | --- Comment #37 from Neil Horman <nhorman@xxxxxxxxxx> --- yes, Rick, I know what jar files are. Let me try to be very clear in what I'm saying: opa-fmgui, when built contains three categories of jar files: 1) Jar files built from the sources that are unique to opa-fmgui 2) Jar files that are built from sources that you include in the upstream opa-fmgui source repository, but are available independently as their own fedora packages (hibernate and jfreechart fall into this category) 3) Jar files that are built from sources that you include in the upstream opa-fmgui source repository, and are _not_ independently available as their own fedora packages (gritty falls into this category) Category 1 Jar files are a no-brainer. They should be licenced with a fedora approved license, and that license should be included in the package. I don't think we have any disagreement here Category 2 Jar files, are what I'm driving at. You shouldn't need those jar files at all, because the jar files can be made available via the Requires tag in the spec file. That is to say, you can require that the hibernate and jfreechart be installed when the opa-fmgui package is installed, so that the jar files from the hibernate and jfreechart packages are used at run time when opa-fmgui is run. As such, you don't need to build those jars. You can remove them from your build, and in so doing, you don't need to include the license with them, because you're not (or shouldn't be) packaging them. Category 3 jar files, I'm willing to give you a waiver on. gritty I would normally say needs to be separately packaged, but because the upstream package is not being actively developed, I don't expect there will be a great need for it, and its just as likely you will do your own internal fixes to it going forward. You will need to include the license file for gritty of course, and it will need to be an approved open source license (like GPL), but as long as it is, that should be fine. If there is a 4th category of jar file I'm unaware of in the project, we will definitely have to address that as well, but I don't see any at the moment -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx