https://bugzilla.redhat.com/show_bug.cgi?id=1323186 Neil Horman <nhorman@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo? | --- Comment #24 from Neil Horman <nhorman@xxxxxxxxxx> --- I'm not worried about the license address, no, and would waive them, though you should contact upstream for those projects and provide them with patches to fix that. What worries me more is how you incorporated those projects to yours. While theres no license issue with doing so, of the three packages that you incorporate: jfreechart is already independently packaged for fedora hibernate is already independently packaged for fedora gritty is not packaged, but easily could be I'm sorry I didn't notice your 3rd party incorporations previously, but as a rule, you may not do that. separate projects need to be packaged independently so that other applications can use them and pick up updates automatically. At a minimum you need to not build or package the jfreechart and hibernate code, instead creating a BuildRequires for the corresponding existing packages, so those are used properly. Ideally you would also package gritty separately, but I can likely waive that as its not currently packaged. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx