https://bugzilla.redhat.com/show_bug.cgi?id=1339029 --- Comment #1 from Dan Williams <dan.j.williams@xxxxxxxxx> --- Spec file comments: > %define rpm_name libintelnvm-cim > %define build_version 1.0.0.1036 > %define build_release 1 > %define dname %{rpm_name}-devel Delete these variables and just use the values directly. > Source: https://github.com/01org/intelnvmcimlibrary/archive/v%{version}.tar.gz Switch this naming scheme to libintelnvm-cim-%{version}.tar.gz > %define debug_package %{nil} I think you can just delete this. > %build > make BUILDNUM=%{build_version} RELEASE=1 This seems to defeat, or otherwise not consider the distro provided compiler flags. > %defattr(755,root,root,755) All the usages of defattr in the spec file are either redundant, because rpm can figure it out itself, or broken in the case of the LICENSE file being inadvertently marked executable. fedora-review reports the following, which all seem to be valid: libintelnvm-cim.x86_64: W: incoherent-version-in-changelog 1.0.0.1036 ['1.0.0.1036-1.fc24', '1.0.0.1036-1'] libintelnvm-cim.x86_64: W: unstripped-binary-or-object /usr/lib64/libintelnvm-cim.so.1.0.0 libintelnvm-cim.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/libintelnvm-cim.so.1.0.0 ['/opt/intel/bin'] libintelnvm-cim.x86_64: W: no-documentation libintelnvm-cim.x86_64: E: script-without-shebang /usr/share/licenses/libintelnvm-cim/LICENSE libintelnvm-cim-devel.x86_64: W: only-non-binary-in-usr-lib libintelnvm-cim-devel.x86_64: W: no-documentation libintelnvm-cim-devel.x86_64: E: script-without-shebang /usr/share/licenses/libintelnvm-cim-devel/LICENSE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx