https://bugzilla.redhat.com/show_bug.cgi?id=1338140 --- Comment #5 from MartinKG <mgansser@xxxxxxxx> --- (In reply to Raphael Groner from comment #4) > My suggestion to run a complete new package review. Some general advice: > > - Are you sure about all BuildRequires? Why subversion-devel? done > > - You can remove Group tag, it's obsolete. done > > - Please provide a proper patch for the desktop file. It makes it easier for > further updates. > > # deleting Unity parts in guayadeque.desktop files > > sed -i '18,38d' runtime/guayadeque.desktop done > > - Are all of the explicit arguments to %cmake needed? Can you build with > debug > flags instead of release? > > -DCMAKE_BUILD_TYPE='Release' > > -DCMAKE_INSTALL_PREFIX='%{_prefix}' > ... dropped a few Options that are already in %cmake macro Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/guayadeque.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/guayadeque-0.4.1-0.3.beta1git35561f6.fc24.src.rpm %changelog * Sun May 22 2016 Martin Gansser <martinkg@xxxxxxxxxxxxxxxxx> - 0.4.1-0.3.beta1git35561f6 - Update to 0.4.1-0.3.beta1git35561f6 - Dropped BR subversion-devel - Removed Group tag, it's obsolete - Addes %%{name}-desktop.patch - Dropped -DCMAKE_INSTALL_PREFIX='%%{_prefix}' because it's already in %%cmake macro - Changed -DCMAKE_BUILD_TYPE='Release' to -DCMAKE_BUILD_TYPE='Debug' -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx