[Bug 1338140] Review Request: guayadeque - Music player

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1338140



--- Comment #4 from Raphael Groner <projects.rg@xxxxxxxx> ---
My suggestion to run a complete new package review. Some general advice:

- Are you sure about all BuildRequires? Why subversion-devel?

- You can remove Group tag, it's obsolete.

- Please provide a proper patch for the desktop file. It makes it easier for
  further updates.
> # deleting Unity parts in guayadeque.desktop files
> sed -i '18,38d' runtime/guayadeque.desktop

- Are all of the explicit arguments to %cmake needed? Can you build with debug 
  flags instead of release?
> -DCMAKE_BUILD_TYPE='Release'
> -DCMAKE_INSTALL_PREFIX='%{_prefix}' 
...

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]