https://bugzilla.redhat.com/show_bug.cgi?id=1332605 Till Hofmann <hofmann@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Till Hofmann <hofmann@xxxxxxxxxxxxxxxxxxx> --- (In reply to Jerry James from comment #2) > (In reply to Till Hofmann from comment #1) > > - Why do you have some documentation in /usr/lib/gap/pkg/openmath/doc and > > some in /usr/share/doc/gap-pkg-openmath/? Does gap expect documentation in > > /usr/lib/gap/? Why not put everything in /usr/share/doc? > > Yes, gap has an online documentation browser, which expects to find > documentation alongside the actual code (actually, wherever PackageInfo.g > says the documentation is located). The files in /usr/share/doc are those > that the online documentation browser would not look for. > That makes sense, so this is okay. > > rpmlint: > > gap-pkg-openmath.noarch: E: incorrect-fsf-address > > /usr/share/licenses/gap-pkg-openmath/GPL > > --> This should be reported upstream. > > Okay, I will do so. Thank you for the review! Thanks for packaging! Approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx