https://bugzilla.redhat.com/show_bug.cgi?id=1332605 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- (In reply to Till Hofmann from comment #1) > - Why do you have some documentation in /usr/lib/gap/pkg/openmath/doc and > some in /usr/share/doc/gap-pkg-openmath/? Does gap expect documentation in > /usr/lib/gap/? Why not put everything in /usr/share/doc? Yes, gap has an online documentation browser, which expects to find documentation alongside the actual code (actually, wherever PackageInfo.g says the documentation is located). The files in /usr/share/doc are those that the online documentation browser would not look for. > - The source files don't have a valid copying permission statement (i.e. a > statement saying 'This file is licensed under GPLv2+') which is not perfect > but not a blocker. I'm afraid that the gap community in general is a little bit sloppy about license notifications, although there are a handful of gap package authors who understand the issues involved and are careful about license statements. > rpmlint: > gap-pkg-openmath.noarch: E: incorrect-fsf-address > /usr/share/licenses/gap-pkg-openmath/GPL > --> This should be reported upstream. Okay, I will do so. Thank you for the review! -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx