https://bugzilla.redhat.com/show_bug.cgi?id=1324590 --- Comment #40 from paul.j.reger@xxxxxxxxx --- (In reply to Michal Schmidt from comment #35) > (In reply to paul.j.reger from comment #32) > > Created attachment 1149512 [details] > > Spec file for 10.1.0. > > in the spec: > > # The source to make this rpm was created at Intel from a private git repo. > > # The source code is available at: https://github.com/01org/opa-psm2/ > > Since your Source0 is now a full URL of a tarball published by the upstream > project, you do not strictly need to comment on its creation. > https://fedoraproject.org/wiki/Packaging:SourceURL requires comments in > other cases, but not in this one. I will toss the comments in my next push of changes to the spec file. > > Source0: https://github.com/01org/opa-psm2/releases/download/10_1/%{name}-%{version}.tar.gz > > Unfortunately the URL is not quite right: > > $ spectool -g -S hfi1-psm.spec > Getting > https://github.com/01org/opa-psm2/releases/download/10_1/hfi1-psm-10.1.0.tar. > gz to ./hfi1-psm-10.1.0.tar.gz > curl: (22) The requested URL returned error: 404 Not Found You are correct that it is not quite correct yet. I did not realize that you were going to try to build it. I thought we were only reviewing the spec file itself. Next time I push changes to the spec file to this review, I will also push a new tarball to git hub. > > # ERRATA: need to add %{optflags} to the build. > > %build > > %{__make} > > Would this work?: > %build > export CFLAGS="%{optflags}" > make %{?_smp_mflags} I will try that. And if that works, I will push this change too, and I will remove the ERRATA comment. For what it is worth, I tried just using: %{__make} CFLAGS="%{optflags}" And our code did not build. I had not fully diagnosed the problem with the failure, but, I assume it is some bug in the Makefile. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx