[Bug 1321438] Review Request: python-breathe - Doxygen xml output to reStructuredText

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1321438



--- Comment #5 from Dave Johansen <davejohansen@xxxxxxxxx> ---
(In reply to Zbigniew Jędrzejewski-Szmek from comment #3)
> You don't need to define %sum. %summary refers to the previous Summary, you
> can just put the text in the first Summary, and then use Summary: %summary.

https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
I was just copying the example from the wiki. Does that need to be updated?

> The description for packages should contain the main part of the description
> too (the user only sees the binary packages).
> 
> I'd suggest:
> %global _description \
> Breathe is an extension to reStructuredText and Sphinx to be able to read and
> render the Doxygen xml output.
> 
> %description %_description
> 
> %description -n python2-breathe %_description
> 
> %description -n python3-breathe %_description
Implemented.

> I don't know why you deleted the _docdir_fmt definition — it would still be
> useful.
I wasn't sure why it was there and my googling indicated that I didn't need to
set it ( https://fedoraproject.org/wiki/Changes/UnversionedDocdirs ).

Should it be set? If so, should it be %{name} (python-breathe) or %{srcname}
(breathe)?

(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> python-breathe-doc.noarch: W: hidden-file-or-dir
> /usr/share/doc/python-breathe-doc/html/.buildinfo
> → please remove.
Done.

The updated files can be found at:
Spec URL:
https://daveisfera.fedorapeople.org/python-breathe_4.2.0/python-breathe.spec
SRPM URL:
https://daveisfera.fedorapeople.org/python-breathe_4.2.0/python-breathe-4.2.0-0.2.fc25.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
http://lists.fedoraproject.org/admin/lists/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]