https://bugzilla.redhat.com/show_bug.cgi?id=1312015 --- Comment #8 from jiri vanek <jvanek@xxxxxxxxxx> --- (In reply to Raphael Groner from comment #7) > (In reply to jiri vanek from comment #6) > … > > Which is the one who build. > > "Java packages MUST BuildRequire their respective build system" and that > means for me that we also have to use it *correctly*, what else sense would > that sentence have? > https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires Thats exactly what I'm doing. Using ant. And "ant" called as it is in this project generates classes. If I would call other possible target - as "ant assembly" then it will generate jar, but ant with assembled and inlcuded all depndencies. I think there is also ant dist, which generates jar. But that jar have in-manifest classpath which is hard to get rid of. AFAIK this step,as I did it, is really ok with guidelines. > > > I call "ant" and then I pack the classes with > > fresh manifest by java -jar. What better can i do? > > Sure. But the ant run does the "pack" for you inclusively. So why do it a > second time and how to handle future upstream changes? It shouldn't be of Explained above. > any relevance if you are upstream as well or not. Hmm okay, it's becoming > more a philosophical question on that level of discussion. > > > That is standard netbeans-project build. I doubt it is handed differently > > somewhere else. And if it is, then all NB projects I ever packed, Are wrong. > > No idea what you did in past and general internals of netbeans build > process. It does not matter for a right review, we've to concentrate on > guidelines and those chnage over time as well. I still hope it is explained above. *however* I'm far from being I'm all knowing. If you know/find the better way how to build NB project generated build files from command-line, then please, share! But I'm not aware, nor was it found in previous review I encountered, nor I myself consider it bad. Spec URL: https://jvanek.fedorapeople.org/offlinesearch/v1/javadocofflinesearch.spec SRPM URL: https://jvanek.fedorapeople.org/offlinesearch/v1/javadocofflinesearch-2.2-1.fc23.src.rpm Description: Tool for offline searching in your docs via browser Fedora Account System Username: jvanek If fixed all I agreed above. Except install of javadoc. I tried, but install command is somehow clumsy in directories. Also I had to fix the find command of yours. Position of -delete meters a lot!-) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review