https://bugzilla.redhat.com/show_bug.cgi?id=1312015 --- Comment #3 from Raphael Groner <projects.rg@xxxxxxxx> --- Let give me some general advice before I can do a run of fedora-review tool. Please fix at least a., d. and j. (MUST). a. License is GPLv3+, you can not downgrade version. MUST https://github.com/judovana/JavadocOfflineSearch/blob/master/LICENSE b. Improve URL and Source0 consistently with macros. RECOMMENDED ¹ URL: https://github.com/judovana/%{srcname} Source0: %{url}/releases/tag/%{srcname}-%{version}/%{srcname}-%{srcname}-%{version}.tar.gz c. Please add a comment what your patch does. SHOULD > Patch1: javadocFixes.patch https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment d. BuildRequires vs. Requires. MUST Why do you need everything listed in BR explicitly also in Requires? Please test to build without any listed Requires and add only those who do not get added automatically via rpmbuild. I think you can definitely remove: - BuildRequires: jpackage-utils - BuildRequires: java-devel - Requires: jpackage-utils - Requires: java-devel https://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires https://fedoraproject.org/wiki/Packaging:Java#BuildRequires_and_Requires e. Description is same as Summary. Alternatively, use text got from upstream documentation. To improve general readability, insert an empty line before %description. SHOULD #Suggestion: %description %{summary} #or: %description The goal of this project was to make searching in your (java)docs as easy and comfortable as when you are browsing them online. https://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description f. Improve removal of binaries. RECOMMENDED - find -name '*.class' -exec rm -f '{}' \; - find -name '*.jar' -exec rm -f '{}' \; + find -print -delete -name '*.class' -or -name '*.jar' g. Installation of jar file is wrong and needs fix. MUST - cp -r dist/javadoc $RPM_BUILD_ROOT/%{_javadocdir}/%{name} + install -m0644 assembly/*.jar -D $RPM_BUILD_ROOT/%{_javadir}/%{name}.jar https://fedoraproject.org/wiki/Packaging:Java#Installation_directory h. Send your start script as a patch to upstream. SHOULD https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment i. Obsolete lines. Please remove. SHOULD > Group: Documentation > %defattr(-,root,root,-) > %defattr(-,root,root,-) (two times %defattr) j. Use %license. MUST - %doc LICENSE + %license LICENSE https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text ¹ RECOMMENDED means here it's a personal preference and not (clearly) in guidelines, it's up to you to decide. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review