https://bugzilla.redhat.com/show_bug.cgi?id=1270357 Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> --- rmplint | grep -v devel-file-in-non-devel-package: nacl-gcc.src:61: W: configure-without-libdir-spec nacl-gcc.src:125: E: hardcoded-library-path in %{_prefix}/lib/gcc/%{gcc_target_platform}/ nacl-gcc.src: W: invalid-url Source0: nacl-gcc-4.4.3-gitf80d6b9.tar.bz2 nacl-gcc.x86_64: W: no-manual-page-for-binary x86_64-nacl-gccbug nacl-gcc.x86_64: W: no-manual-page-for-binary x86_64-nacl-gcc-4.4.3 nacl-gcc.x86_64: W: no-manual-page-for-binary x86_64-nacl-c++ nacl-gcc.x86_64: W: non-standard-dir-in-usr x86_64-nacl All OK. nacl-gcc.x86_64: E: script-without-shebang /usr/x86_64-nacl/lib64/libobjc.la nacl-gcc.x86_64: E: script-without-shebang /usr/x86_64-nacl/lib64/libsupc++.la nacl-gcc.x86_64: E: script-without-shebang /usr/x86_64-nacl/lib64/libstdc++.la nacl-gcc.x86_64: E: script-without-shebang /usr/x86_64-nacl/lib32/libstdc++.la nacl-gcc.x86_64: E: script-without-shebang /usr/x86_64-nacl/lib32/libobjc.la nacl-gcc.x86_64: E: script-without-shebang /usr/x86_64-nacl/lib32/libsupc++.la OK too. There's a rule against .la files, but a compiler is special. 3 packages and 0 specfiles checked; 7 errors, 509 warnings. + license is acceptable (GPLv3+ etc) + license file is present, %license is used + version is not the latest, but it should match chrome, so that's OK + builds and install OK + should not conflict normal gcc (custom prefix or suffix used everywhere) + no scriptlets present or necessary + provides/requires look sane + rpmlint has nothing interesting to say (above) Package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review