[Bug 1292040] Review Request: tng - Trajectory Next Generation binary format manipulation library

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1292040



--- Comment #14 from Dominik 'Rathann' Mierzejewski <dominik@xxxxxxxxxxxxxx> ---
(In reply to Antonio Trande from comment #13)
> (In reply to Dominik 'Rathann' Mierzejewski from comment #12)
> > (In reply to Antonio Trande from comment #11)
> > > Package Review
> > > ==============
> > > 
> > > Legend:
> > > [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> > > [ ] = Manual review needed
> > > 
> > > ==== Issues ====
> > > 
> > > - Please, use %{_pkgdocdir} or %doc macro for documentation files.
> > 
> > I don't understand what you mean here. The spec already does this:
> > %files doc
> > %{_pkgdocdir}
> > 
> > 
> 
> -doc sub-package should provide its own license file;

Right, I'll add it, though I think it's trivial enough to do upon import.

> inside it, I guess you can tag all documentation with %doc without making a
> %{buildroot}%{_defaultdocdir}/tng directory.

No, because then it'll end up in /usr/share/doc/tng-doc. Right now it installs
nicely into /usr/share/doc/tng.

If there's nothing else, please approve.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]