https://bugzilla.redhat.com/show_bug.cgi?id=1317592 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> --- Thx for the upstream query about the separate license file. Here is one minor nit: * Test suite - If you are going to expand the test suite in %prep section, you should use %setup macro together with -a or -b parameter for that [1]. - Nevertheless, the safer option is to expand the test suite in the %check section. This way you will avoid possible pollution of the rebuilt gem and the necessity to copy the test suite. - You don't really need to delete the test suite after execution, unless you insist on using rpmbuild directly (in that case, I can imagine it might cause some issues) Otherwise the package looks sane => APPROVED I am also going to sponsor you now, so please follow with the next steps [2]. But please consider fixing the issues I pointed out above prior importing the package into Fedora. [1] http://www.rpm.org/max-rpm/s1-rpm-inside-macros.html [2] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review