https://bugzilla.redhat.com/show_bug.cgi?id=1317592 Bug ID: 1317592 Summary: Review Request: rubygem-websocket-extensions - Generic extension manager for WebSocket connections Product: Fedora Version: rawhide Component: Package Review Severity: medium Assignee: nobody@xxxxxxxxxxxxxxxxx Reporter: jaruga@xxxxxxxxxx QA Contact: extras-qa@xxxxxxxxxxxxxxxxx CC: package-review@xxxxxxxxxxxxxxxxxxxxxxx Spec URL: http://people.redhat.com/jaruga/git/rubygem-websocket-extensions/rubygem-websocket-extensions.spec SRPM URL: http://people.redhat.com/jaruga/git/rubygem-websocket-extensions/rubygem-websocket-extensions-0.1.2-1.fc25.src.rpm Description: Generic extension manager for WebSocket connections Fedora Account System Username: jaruga Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=13344975 Note: - I prepared tests from upstream following below page. https://fedoraproject.org/wiki/Packaging:Ruby#Test_suites_not_included_in_the_package Source1 URL: http://people.redhat.com/jaruga/git/rubygem-websocket-extensions/rubygem-websocket-extensions-0.1.2-specs.tgz Though for the modification, the rpmlint warns about Source1, I think it is no problem. About the spec file Line 16, I wrote it without macro, because it looks easier to copy from Line 15 to Line16, when we will update the spec file in the future. Thank you for the review. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review