https://bugzilla.redhat.com/show_bug.cgi?id=1307200 --- Comment #3 from Rex Dieter <rdieter@xxxxxxxxxxxx> --- naming: ok sources: ok edb0a82781dbb75d1fe69f2eb6f7cf28 kjots-5.0.1.tar.xz license: ok scriptlets: NOT ok 1. icon scriptlets reference (undefined?) macro: %{_iconsdir}, probably want instead: %{_datadir}/icons (or define %_iconsdir) 2. MUST add appdata validation scriptlet https://fedoraproject.org/wiki/Packaging:AppData#app-data-validate_usage 3. SHOULD use better URL, something like URL: http://projects.kde.org/kjots 4. MUST include licenses in %files, add: %license COPYING and optinally %license COPYING.LIB too -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review