https://bugzilla.redhat.com/show_bug.cgi?id=1284527 --- Comment #24 from Dan Horák <dan@xxxxxxxx> --- (In reply to Vasant Hegde from comment #23) > V5: > - Rebased to latest upstream version (v5.1.13) > - Updated specfile to include pflash and scom tools in opal-utils package > - Updated specfile to build opal-firmware package > > > opal-firmware: > Upstream decided to create 3 packages out of OPAL source code. Hence I've > added this package now. Its a noarch package contains our firmware code in > big endian mode. We can use this code in qemu [1] OK > https://www.flamingspork.com/blog/2015/08/28/running-opal-in-qemu-the- > powernv-platform/ > > > - was up-to-date when updating the review ticket, please update to 5.1.12 > > for the next iteration > > - distro-wide CFLAGS are not used, try setting CFLAGS="%{optflags}" for the > > make call in %build, see > > I've added above flag except one place where we always want to build big > endian firmware. no problem, makes sense, the distro wide flags are meant for regular binaries/libs, firmwares can have different requirements > > - my scratch build = > > http://ppc.koji.fedoraproject.org/koji/taskinfo?taskID=3077491 > > - please update the scriptlets and Requires to the current style, see > > https://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Systemd > > I've added. But looks like its not starting daemon automatically. Is there a > way to start daemon as soon as we install it? > (systemd_post opal-prd.service -> calls systemctl preset) Still missing are the Requires(post|preun|postun) tags mentioned in the guideline, they are required for the scriptlets to work. The systemd guideline links to https://fedoraproject.org/wiki/Packaging:DefaultServices?rd=Starting_services_by_default for how to handle default state of services. But we can solve the default behaviour after including the package in the distro. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review