https://bugzilla.redhat.com/show_bug.cgi?id=1305382 --- Comment #5 from Denis Fateyev <denis@xxxxxxxxxxx> --- (In reply to Raphael Groner from comment #3) >> 2) Please add all BRs: coreutils, gcc-c++, sed; > Not a good idea IMHO. You can expect everything being installed that rpm > depends on. As bash (and mock installing bash) depends on coreutils' > functionality and rpm package depends on it, we can guess a functional build > environment when rpm is installed by rpmbuild. > https://lists.fedoraproject.org/pipermail/devel/2015-June/211423.html Well, for all the details, just in case: - if you follow the fpc ticked mentioned, you'll see the latest writeup: https://fedorahosted.org/fpc/ticket/540#comment:26 which leads to: https://fedoraproject.org/wiki/Packaging:C_and_C%2B%2B?rd=C_and_C which requires `gcc-c++`; - for `coreutils`: > You can expect everything being installed that rpm depends on. we shouldn't expect that the current build procedure along the dependencies won't be changed ever. Better not to rely on inter-package deps that *currently* present in buildroot but point `coreutils` BR explicitly if we use its functionality in this very spec. - for `sed`: it should be used, seems there's no doubt. >> 3) README.md isn't a pure license; it can be simply in `%doc`; > Couriously enough, README.md includes the license text for this package, > so I decided to use that file for %license. Yeah, but it also contain some common information about the package. Generally speaking, it's not that strange to meet README file with license in `%doc` (like older Redora/RH distributions always did), but a bit uncommon to have general instructions in `%license`. Better solution would be split license and README into appropriate files, but meanwhile I believe that `%doc` would be a better location here. >> 6) Better get rid of macros in comments to eliminate rpmlint warnings. > That's intentional as a reminder cause of the failing tests and should not > harm on koji for the official builds, see above. Well, it's up to you and actually doesn't break things; but I would unwrap %{name} just to eliminate warnings. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review