https://bugzilla.redhat.com/show_bug.cgi?id=1306615 Petr Šabata <psabata@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> --- * Missing a buildtime dep: - Data::Dumper, used in t/dbi.t, t/lib.pl and t/sql_interp.t * The `perl(DBI.*)' filter is quite dangerous and might cause problems in the future if people overlook it. Perhaps filtering DBI and DBI::db would be a better option. * I see you've already reported RT#111948, good. * Filter::Simple and Text::Balanced aren't probably needed but since upstream lists them in the metadata, I won't consider this an error. Only the first point really needs fixing. Do so before building the package. Approving this now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review