https://bugzilla.redhat.com/show_bug.cgi?id=1245889 --- Comment #12 from Stefan Nuxoll <stefan@xxxxxxxxxxxxx> --- (In reply to Miroslav Suchý from comment #11) > There should be no line after %description (otherwise the blank line goes to > description as well). It should be: > %description > A simple database ... > > Instead of > %{__python2} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT > you should call: > %{py2_build} > or use %{optflags} macro which pass various other option e.g. -O2 and > hardened build. The same for python3 build. > > Also the tar contains tests. Can you run them in %check section? > > Tar file contains various documentation. You can add them to package (or to > -doc subpackage) as > %files doc > %doc docs/*.rst > %doc docs/ref/*.rst > %doc docs/conf.py > %doc *.rst optflags are passed when setup.py is called in the build phase, they are not passed in the install phase as the native extensions have already been build. Are the py2_build/py3_build and py2_install/py3_install macros supported by the EPEL buildroots? If so I have no problem using them, otherwise as EPEL7 support is desired for this package the 'old' way suffices. Unfortunately as the unit tests for this project require access to a MS SQL Server database running them inside the rpm check phase isn't going to make much sense. I can certainly build the documentation and add it to a doc package and fix the description formatting. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review