[Bug 1245889] Review Request: python-pymssql - Microsoft SQL Server adapter for Python

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1245889



--- Comment #11 from Miroslav Suchý <msuchy@xxxxxxxxxx> ---
There should be no line after %description (otherwise the blank line goes to
description as well). It should be:
%description
A simple database ...

Instead of
%{__python2} setup.py install -O1 --skip-build --root $RPM_BUILD_ROOT
you should call:
  %{py2_build}
or use %{optflags} macro which pass various other option e.g. -O2 and hardened
build. The same for python3 build.

Also the tar contains tests. Can you run them in %check section?

Tar file contains various documentation. You can add them to package (or to
-doc subpackage) as
%files doc
%doc docs/*.rst
%doc docs/ref/*.rst
%doc docs/conf.py
%doc *.rst

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review




[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]