Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xzgv - A GTK+/Imlib-based picture viewer for X https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=244702 ------- Additional Comments From terjeros@xxxxxxxxxxxx 2007-06-20 17:50 EST ------- > 1. You might add "|| :" to the end of your install-info calls. > 2. Might add AUTHORS and NEWS as doc files? > 3. You should use %{?_smp_mflags} > 4. You seem to be missing BuildRequires: desktop-file-utils > 5. The "Application" Categories in your desktop file is no longer used. > 6. Is redhat-graphics an appropriate icon for this app? All should be fixed, I switch icon to eog in absent of something better. SPEC: http://web.phys.ntnu.no/~terjeros/xzgv/xzgv.spec SRPM: http://web.phys.ntnu.no/~terjeros/xzgv/xzgv-0.8-2.fc7.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review